The of_address_to_resource returns 0 if successful. gic_check_eoimode calls it without checking the return value. This induces Coverity warning: "Unchecked return value".
Return false from gic_check_eoimode if of_address_to_resource returns non-0 value. Signed-off-by: Bo Yan <b...@nvidia.com> --- drivers/irqchip/irq-gic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index ced10c4..0bceb10 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -1284,7 +1284,8 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base) { struct resource cpuif_res; - of_address_to_resource(node, 1, &cpuif_res); + if (of_address_to_resource(node, 1, &cpuif_res)) + return false; if (!is_hyp_mode_available()) return false; -- 2.7.4