On Tue, 19 Jun 2007, Mel Gorman wrote: > When other mechanisms exist, they would be added here. Right now, > isolate_lru_page() is the only one I am aware of.
Did you have a look at kmem_cache_vacate in the slab defrag patchset? > > You do not need to check the result of migration? Page migration is a best > > effort that may fail. > You're right. I used to check it for debugging purposes to make sure migration > was actually occuring. It is not unusual still for a fair number of pages > to fail to migrate. migration already uses a retry logic and I shouldn't > be replicating it. > > More importantly, by leaving the pages on the migratelist, I potentially > retry the same migrations over and over again wasting time and effort not > to mention that I keep pages isolated for much longer than necessary and > that could cause stalling problems. I should be calling putback_lru_pages() > when migrate_pages() tells me it failed to migrate pages. No the putback_lru is done for you. > I'll revisit this one. Thanks You could simply ignore it if you do not care if its migrated or not. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
