On Tue, Jun 19, 2007 at 02:51:25PM +0200, Geert Uytterhoeven wrote: > On Tue, 19 Jun 2007, Christoph Hellwig wrote: > > On Fri, Jun 15, 2007 at 01:39:23PM +0200, Geert Uytterhoeven wrote: > > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > > > Add a Disk Storage Driver for the PS3: > > > - Implemented as a block device driver with a dynamic major > > > - Disk names (and partitions) are of the format ps3d%c(%u) > > > - Uses software scatter-gather with a 64 KiB bounce buffer as the > > > hypervisor > > > doesn't support scatter-gather > > > > Looks good to me. Only nitpicks are: > > > > - ps3disk_priv should probably be an inline function instead of a macro > > I used a macro because you can do > > ps3disk_pri(dev) = ...;
I'm not exactly a fan of macros used as lvalues, but if you really want this it can go in. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
