Hi Niels,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on fuse/for-next]
[also build test ERROR on v4.18-rc2 next-20180626]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Niels-de-Vos/fuse-add-support-for-copy_file_range/20180627-155404
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git 
for-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

>> fs//fuse/file.c:3092:21: error: initialization of 'ssize_t (*)(struct file 
>> *, loff_t,  struct file *, loff_t,  size_t,  unsigned int)' {aka 'int 
>> (*)(struct file *, long long int,  struct file *, long long int,  unsigned 
>> int,  unsigned int)'} from incompatible pointer type 'long int (*)(struct 
>> file *, loff_t,  struct file *, loff_t,  size_t,  unsigned int)' {aka 'long 
>> int (*)(struct file *, long long int,  struct file *, long long int,  
>> unsigned int,  unsigned int)'} [-Werror=incompatible-pointer-types]
     .copy_file_range = fuse_copy_file_range,
                        ^~~~~~~~~~~~~~~~~~~~
   fs//fuse/file.c:3092:21: note: (near initialization for 
'fuse_file_operations.copy_file_range')
   cc1: some warnings being treated as errors

vim +3092 fs//fuse/file.c

  3075  
  3076  static const struct file_operations fuse_file_operations = {
  3077          .llseek         = fuse_file_llseek,
  3078          .read_iter      = fuse_file_read_iter,
  3079          .write_iter     = fuse_file_write_iter,
  3080          .mmap           = fuse_file_mmap,
  3081          .open           = fuse_open,
  3082          .flush          = fuse_flush,
  3083          .release        = fuse_release,
  3084          .fsync          = fuse_fsync,
  3085          .lock           = fuse_file_lock,
  3086          .flock          = fuse_file_flock,
  3087          .splice_read    = generic_file_splice_read,
  3088          .unlocked_ioctl = fuse_file_ioctl,
  3089          .compat_ioctl   = fuse_file_compat_ioctl,
  3090          .poll           = fuse_file_poll,
  3091          .fallocate      = fuse_file_fallocate,
> 3092          .copy_file_range = fuse_copy_file_range,
  3093  };
  3094  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to