2018-06-25 18:06 GMT+02:00 David Lechner <da...@lechnology.com>: > On 06/25/2018 11:01 AM, Bartosz Golaszewski wrote: >> >> 2018-06-25 17:53 GMT+02:00 David Lechner <da...@lechnology.com>: >>> >>> On 06/25/2018 10:29 AM, Bartosz Golaszewski wrote: >>>> >>>> >>>> From: Bartosz Golaszewski <bgolaszew...@baylibre.com> >>>> >>>> We want to be able to get the clock both from the board file by its >>>> con_id and from the aemif driver by dev_id. >>> >>> >>> >>> What about the other SoCs? Don't they need this change as well? >>> >> >> So I double checked and turns out I missed one other board that's >> affected by this series and calls clk_get() from machine code: >> dm644x-evm. >> >> I'll fix it in v2. > > > The ti-aemif platform driver also does clk_get(). Don't you need > lookups to make that work as well? For example, DA830 doesn't have > a clock lookup for aemif at all. >
This seems like a bug: in arch/arm/mach-davinci/aemif.c in current mainline we do call clk_get() for 'aemif' and it's called indirectly from board-da830-evm.c via davinci_aemif_setup(). I'll address this too in v2. Bart
