On 25/06/2018 10:23, Rafael J. Wysocki wrote:
[ ... ]
>> + * It is up to the user of this framework to provide a lock at an
>> + * upper level to prevent stupid things to happen, like starting while
>> + * we are unregistering.
>> + */
>
> The English above and elsewhere needs some polishing IMO, but I can
> take care of that. :-)
I can give a try and if you are still unhappy, you change them in a
better way.
[ ... ]
>> +static void idle_injection_setup(unsigned int cpu)
>> +{
>> + struct sched_param param = { .sched_priority = MAX_USER_RT_PRIO / 2
>> };
>> +
>> + set_freezable();
>
> Why do you need set_freezable() here?
We don't want to continue injecting idle cycles when the system is
suspended.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
