Hi, On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd <swb...@chromium.org> wrote: > When requesting a gpio as an interrupt, we should make sure to mux the > pin as the GPIO function and configure it to be an input so that various > functions or output signals don't affect the interrupt state of the pin. > So far, we've relied on pinmux configurations in DT to handle this, but > let's explicitly configure this in the code so that DT implementers > don't have to get this part right. > > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: Doug Anderson <diand...@chromium.org> > Signed-off-by: Stephen Boyd <swb...@chromium.org> > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 37 ++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+)
This seems like a reasonable idea to me. I'm not a huge fan of all the boilerplate code copied from gpiochip_irq_reqres() and gpiochip_irq_relres(), but it looks like that's the way it's done at the moment. Thus: Reviewed-by: Douglas Anderson <diand...@chromium.org>
