On Mon, Jun 11, 2018 at 5:32 PM Laura Abbott <labb...@redhat.com> wrote:
>
> v4 takes Linus' suggestion of using linker fill to insert the build id.
Heh. I was hoping somebody would come up with a way to avoid my crazy
"put a LONG into an aligned section to cause alignment filling" thing.
Because somebody will ask "what the heck is the meaning of that
LONG(0xffaa5500) thing"?
But since I couldn't come up with anything better myself, I guess I
can't complain.
> This is pretty small but I also know people can be picky so I'm open to
> opinions or suggestions here.
I'm not sure anybody will care about 32 bytes. Although maybe it could
be made to be just 8 bytes (four bytes to force padding, four bytes of
padding) and put somewhere where you'll have more padding anyway due
to being followed by a PAGE_ALIGNED section or something?
I don't think we care.
Anyway, I'll pull this if somebody sends it to me, it seems to be
fairly minimally invasive and apparently fixes an issue for distros.
Linus
