Hi Viresh, thanks for the comment, On Thu, Jun 07, 2018 at 10:15:43AM +0530, Viresh Kumar wrote: > On 07-06-18, 11:17, Chen Yu wrote: > > diff --git a/drivers/cpufreq/cpufreq_governor.c > > b/drivers/cpufreq/cpufreq_governor.c > > index 871bf9c..9792c80 100644 > > --- a/drivers/cpufreq/cpufreq_governor.c > > +++ b/drivers/cpufreq/cpufreq_governor.c > > @@ -165,7 +165,7 @@ unsigned int dbs_update(struct cpufreq_policy *policy) > > * calls, so the previous load value can be used then. > > */ > > load = j_cdbs->prev_load; > > - } else if (unlikely(time_elapsed > 2 * sampling_rate && > > + } else if (((int)idle_time > 0) && unlikely(idle_time > 2 * > > sampling_rate && > > Yes the figures are insane, but if the idle time is around 36 minutes, the > conversion to int will make a positive value look negative and we will exit > the > conditional block. And if we don't think that we will ever get such insane > idle > times or we don't want to care about them, then what about doing this instead: > > } else if ((unlikely((int)idle_time > 2 * sampling_rate && > > same below. > Yes, this would be more straightforward.
Best, Yu > -- > viresh
