On 30 May 2018 at 2:07PM Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote:
>On 30 May 2018 at 07:58, Ingo Molnar <mi...@kernel.org> wrote: >> >> * nixiaoming <nixiaom...@huawei.com> wrote: >> >>> mark_rodata_ro is only called by the function mark_readonly >>> when CONFIG_STRICT_KERNEL_RWX=y >>> >>> if CONFIG_STRICT_KERNEL_RWX is not set >>> a compile warning may be triggered: unused function >.... >> >> NAK, this is very ugly and the changelog doesn't appear to be true: the build >> warning does not trigger in the default build, correct? >> > >I don't see how the build warning could trigger at all, given that >mark_rodata_ro() has external linkage. > Unable to set CONFIG_STRICT_KERNEL_RWX=n by make menuconfig ARCH=x86_64 the build warning does not trigger in the default build, but it should be more appropriate to add CONFIG control to the code.
