On Thursday 14 June 2007, Christoph Hellwig wrote: > Christophs patches are an extremly useful cleanup and can stand on their > own. Right now PAGE_CACHE_SIZE and friends are in there and now one can > keep them distinct because their useage is not clear at all. By making > the macros per-mapping at least the useage is clear. > > That beeing said we should do a full conversion so that PAGE_CACHE_SIZE > just goes away, otherwise the whole excercise is rather pointless.
I agree with Christoph and Christoph here. The page_cache_xxx() macros are cleaner than PAGE_CACHE_SIZE. Too many places have gotten it wrong too many times. Let's go ahead with them even if we never implement variable cache page size. Dave McCracken - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/