On 05/17/2018 02:23 PM, Doug Anderson wrote: > On Fri, May 11, 2018 at 7:28 PM, David Collins <colli...@codeaurora.org> > wrote: >> + /* >> + * Default the voltage selector to an error value in >> the >> + * case that qcom,regulator-initial-microvolt is not >> + * specified in device tree since the true voltage is >> + * not known. Note that this value causes >> + * devm_regulator_register() to fail in the case that >> + * regulator-min-microvolt and >> regulator-max-microvolt >> + * are specified in device tree due to >> + * machine_constraints_voltage() bailing when the >> + * get_voltage_sel() callback returns this error >> value. >> + */ >> + vreg->voltage_selector = -EINVAL; > > As per comments in other threads, adjust this comment and use > -ENOTRECOVERABLE now.
I'll make this change. Take care, David -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
