> From: devel <driverdev-devel-boun...@linuxdriverproject.org> On Behalf Of > Stephen Hemminger > Sent: Sunday, May 13, 2018 10:24 > > ... > > @@ -372,6 +400,18 @@ int vmbus_post_msg(void *buffer, size_t buflen, > bool can_sleep) > > ... > > + hdr = (struct vmbus_channel_message_header *)buffer; > > Hate to pick o the details, but buffer is void * so cast is not necessary > here.
Yes, it's unnecessary in C, though it's necessary in C++. I found the patch went into char-misc 4 hours ago, so it looks we may as well leave it as is. IMHO an explicit cast is not a bad thing. :-) Thanks, -- Dexuan
