On Tue, May 08, 2018 at 04:27:26PM +0200, Stefan Agner wrote: > Mixing asm and C code is not recommended in a naked function by > gcc and leads to an error when using clang: > drivers/bus/arm-cci.c:2107:2: error: non-ASM statement in naked > function is not supported > unreachable(); > ^ > > While the function is marked __naked it actually properly return > in asm. There is no need for the unreachable() call. > > GCC 7.2 generates identical object files before and after, other > than (for obvious reasons) the line numbers generated by > WANT_WARN_ON_SLOWPATH for all the WARN()s appearing later in the > file. > > Suggested-by: Russell King <li...@arm.linux.org.uk> > Signed-off-by: Stefan Agner <ste...@agner.ch> > Acked-by: Nicolas Pitre <n...@linaro.org> > Reviewed-by: Robin Murphy <robin.mur...@arm.com> > --- > Changes in v3: > - Fix subject and enhance commit message > Changes in v2: > - Don't add assembly ASM_UNREACHABLE, just drop unreachable()
Applied to next/drivers for v4.18 merge window now. Thanks! -Olof
