Hi Andy Shevchenko > -----邮件原件----- > 发件人: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > 发送时间: 2018年5月14日 15:17 > 收件人: songxiaowei <songxiao...@hisilicon.com> > 抄送: chenyao (F) <chenya...@huawei.com>; Wangbinghui > <wangbing...@hisilicon.com>; Lorenzo Pieralisi <lorenzo.pieral...@arm.com>; > Bjorn Helgaas <bhelg...@google.com>; xuwei (O) <xuw...@huawei.com>; > Rob Herring <robh...@kernel.org>; Mark Rutland <mark.rutl...@arm.com>; > Catalin Marinas <catalin.mari...@arm.com>; Will Deacon > <will.dea...@arm.com>; linux-...@vger.kernel.org; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; linux-arm Mailing List > <linux-arm-ker...@lists.infradead.org>; devicetree > <devicet...@vger.kernel.org>; dimitr...@google.com; > guodong...@linaro.org; Suzhuangluan <suzhuangl...@hisilicon.com>; Kongfei > <kong...@hisilicon.com> > 主题: Re: reply: [PATCH v3 1/2] PCI: kirin: Add MSI support > > On Mon, May 14, 2018 at 4:11 AM, songxiaowei <songxiao...@hisilicon.com> > wrote: > > >> > + int ret; > >> > + > >> > + if (IS_ENABLED(CONFIG_PCI_MSI)) { > >> > >> > + pci->pp.msi_irq = platform_get_irq(pdev, 0); > >> > + if (pci->pp.msi_irq < 0) { > >> > + dev_err(&pdev->dev, "failed to get MSI IRQ > >> (%d)\n", > >> > + pci->pp.msi_irq); > >> > >> > + return -ENODEV; > >> > >> Why shadowing actual error code? > > [songxiaowei] Sorry, I can't get your point about this, would you explain > > it > for me. > > platform_get_irq() returns either correct IRQ number or negative error code. > In the code above you shadow the actual error (as returned by that > call) by -ENODEV. Any reason why? > [songxiaowei] I guess the reason is that she wanted to keep the same with other hosts, So, you'd like to use "return pci->pp.msi_irq " instead of " return -ENODEV ". > -- > With Best Regards, > Andy Shevchenko
Thanks a lot, Xiaowei.
