Hi Gary,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on iommu/next]
[also build test ERROR on v4.17-rc4 next-20180507]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Gary-R-Hook/iommu-Enable-debugfs-exposure-of-IOMMU-driver-internals/20180508-062918
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-randconfig-x016-201818 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/intel-iommu.h:32:0,
                    from drivers/gpu/drm/i915/i915_drv.h:41,
                    from drivers/gpu/drm/i915/i915_oa_bxt.c:31:
   include/linux/iommu.h: In function 'iommu_debugfs_new_driver_dir':
>> include/linux/iommu.h:706:8: error: parameter name omitted
    struct dentry *iommu_debugfs_new_driver_dir(char *) {};
           ^~~~~~
   In file included from include/linux/intel-iommu.h:32:0,
                    from drivers/gpu/drm/i915/i915_drv.h:41,
                    from drivers/gpu/drm/i915/i915_oa_bxt.c:31:
>> include/linux/iommu.h:706:8: warning: control reaches end of non-void 
>> function [-Wreturn-type]
    struct dentry *iommu_debugfs_new_driver_dir(char *) {};
           ^~~~~~

vim +706 include/linux/iommu.h

   700  
   701  #ifdef CONFIG_IOMMU_DEBUGFS
   702  void iommu_debugfs_setup(void);
   703  struct dentry *iommu_debugfs_new_driver_dir(char *);
   704  #else
   705  static inline void iommu_debugfs_setup(void) {}
 > 706  struct dentry *iommu_debugfs_new_driver_dir(char *) {};
   707  #endif
   708  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to