When ipc test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <sh...@kernel.org>
---
 tools/testing/selftests/ipc/msgque.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/ipc/msgque.c 
b/tools/testing/selftests/ipc/msgque.c
index ee9382bdfadc..dac927e82336 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -196,10 +196,9 @@ int main(int argc, char **argv)
        int msg, pid, err;
        struct msgque_data msgque;
 
-       if (getuid() != 0) {
-               printf("Please run the test as root - Exiting.\n");
-               return ksft_exit_fail();
-       }
+       if (getuid() != 0)
+               return ksft_exit_skip(
+                               "Please run the test as root - Exiting.\n");
 
        msgque.key = ftok(argv[0], 822155650);
        if (msgque.key == -1) {
-- 
2.14.1

Reply via email to