On 05/04/2018 06:56 AM, Shiju Jose wrote:
Hi Alex,
Hi
-----Original Message-----
From: Alexandru Gagniuc [mailto:mr.nuke...@gmail.com]
[snip]
-static inline int ghes_severity(int severity)
+static inline int ghes_cper_severity(int severity)
[...]
else
ratelimit = &ratelimit_uncorrected;
@@ -705,9 +705,8 @@ static int ghes_proc(struct ghes *ghes)
if (rc)
goto out;
- if (ghes_severity(ghes->estatus->error_severity) >=
GHES_SEV_PANIC) {
+ if (ghes_cper_severity(ghes->estatus->error_severity) >=
GHES_SEV_PANIC)
__ghes_panic(ghes);
PCIe AER fatal errors result panic here.
I think ghes_cper_severity to be replaced with ghes_severity in the ghes_proc
function as well in the patch
"acpi: apei: Do not panic() on PCIe errors reported through GHES"?
Hmm.
ghes_proc calls ghes_do_proc, which is not irq safe. So the entire
concern we had in v1 about deferring to a less restrictive context is
moot in this case.
ghes_proc is related, but a little beyond the scope of this series. I'd
love to fix all cases, but I'd prefer someone who has specific interests
take ownership of changing ghes_proc.
Alex
