On Fri, 2007-06-08 at 09:23 +0200, Hans-Christian Egtvedt wrote:
> On Thu, 2007-06-07 at 16:09 -0700, Andrew Morton wrote:
> > On Wed, 6 Jun 2007 16:04:07 +0200
> > Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote:
> >
> > > This patch adds support for the built in watchdog in AT32AP700X devices.
> > >
> > > Tested on AT32AP7000 and ATSTK1000.
> > >
> > > Hardware documentation can be found in the AT32AP7000 datasheet.
> > >
> > > ...
> > >
> > > +static int __init at32_wdt_probe(struct platform_device *pdev)
> > > +{
>
> <cut start of _probe>
>
> > > + wdt->regs = ioremap(regs->start, regs->end - regs->start + 1);
> >
> > I see an ioremap(), but there are no iounmap()s anywhere.
>
> Hmm, that would be my fault, please see the attach patch, it should
> apply clean to -mm after your two -fix{1,2} patches.I missed iounmap if the probe function fails, the included patch corrects this. Applies after the previous patches. Do you want me to fold all five patches? original + fix1 and fix2 + iounmap patches. Sorry for the minor fixes. -- With kind regards, Hans-Christian Egtvedt, siv.ing. (M.Sc.) Applications Engineer - AVR32 System Solutions - Atmel Norway
0001-at32ap700x-wdt-add-iounmap-if-probe-function-fails.txt
Description: application/mbox
