Davide Libenzi <[EMAIL PROTECTED]> wrote:
> The sys_accept() system call has been modified to return a file
> descriptor inside the non-sequential area, if the listening fd is.
> - newfd = sock_alloc_fd(&newfile);
> + newfd = sock_alloc_fd(&newfile,
> + fd > current->signal->rlim[RLIMIT_NOFILE].rlim_cur ? O_NONSEQFD: 0);
This will break apps that change/downgrade their rlimit (after getting a high
fd listen socket)
Yes probably insane, but who knows...
sock = socket(...);
bind(...);
listen(sock, backlog); ...
fd = dup2(sock, 1023);
close(sock);
setrlimit( RLIMIT_NOFILE, rlim.rlim_cur = 256);
...
while ((newsock = accept(fd, ...)) != -1) {
fork();...
Plain legacy code, expecting newsock being *small*
FD_SET(newsock , &rd_set);
...oops... fd is too large to fit in fd_set
select(newsock + 1, &rd_set, ...);
}
So you might change logic to straight :
newfd = sock_alloc_fd(&newfile, (fd >= FDMAP_NONSEQ_BASE) ? O_NONSEQFD: 0);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
