On Thu, Jun 07, 2007 at 06:37:02PM +0900, Paul Mundt wrote:
> On Thu, Jun 07, 2007 at 11:19:42AM +0200, Manuel Lauss wrote:
> > On Thu, Jun 07, 2007 at 04:11:38PM +0900, Paul Mundt wrote:
> > > On Wed, Jun 06, 2007 at 11:42:31PM -0700, William Lee Irwin III wrote:
> > > > sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol
> > > > 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'
> >
> > ---
> >
> > Make SND_SOC_PCM_SH7760 depend on SH_DMABRG rather than selecting it
> >
> > Fixes Kconfig warning about undefined SH_DMABRG symbol on non-sh builds.
> >
> Are you sure this is the way you want to go? The select here is
> reasonably useful.
I hope the other people using this code are smart enough to set SH_DMABRG in
their board's defconfig. (I seem to remember there was an argument about
the evilness of select; and as far as I know I am the only user of this
code anyway)
If you think select is more useful then I'll send another patch to the
alsa folks.
Thanks,
Manuel Lauss
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
