On Fri, Apr 20, 2018 at 7:38 AM, Eric W. Biederman
<[email protected]> wrote:
> Filling in struct siginfo before calling force_sig_info a tedious and
> error prone process, where once in a great while the wrong fields
> are filled out, and siginfo has been inconsistently cleared.
>
> Simplify this process by using the helper force_sig_fault.  Which
> takes as a parameters all of the information it needs, ensures
> all of the fiddly bits of filling in struct siginfo are done properly
> and then calls force_sig_info.
>
> In short about a 5 line reduction in code for every time force_sig_info
> is called, which makes the calling function clearer.
>
> Cc: Max Filippov <[email protected]>
> Cc: Chris Zankel <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: "Eric W. Biederman" <[email protected]>
> ---
>  arch/xtensa/kernel/traps.c | 10 +---------
>  arch/xtensa/mm/fault.c     | 19 +++++--------------
>  2 files changed, 6 insertions(+), 23 deletions(-)

Acked-by: Max Filippov <[email protected]>

-- 
Thanks.
-- Max

Reply via email to