On Tue, Apr 3, 2018 at 3:27 PM, Mylène Josserand <mylene.josser...@bootlin.com> wrote: > Hi Chen-Yu, > > Thank you for your review! > > On Tue, 3 Apr 2018 14:52:45 +0800 > Chen-Yu Tsai <w...@csie.org> wrote: > >> On Tue, Apr 3, 2018 at 2:18 PM, Mylène Josserand >> <mylene.josser...@bootlin.com> wrote: >> > To add the support for SMP on sun8i-a83t, we will use some >> > definitions in an assembly file so move definitions into >> > another file to separate C functions and macro defintions. >> >> Instead of moving the definitions, you could guard all the C >> stuff in "#ifndef __ASSEMBLY__". AFAIK a few header files do that. > > Oh, right. It is better with this check so I will use that in the next > iteration of my series.
I'm not sure about the policy, but I kind of assume any header under "asm" would be usable in assembly files, so the guard would be better. ChenYu
