On Fri, Jun 01, 2007 at 02:06:54PM -0400, Mathieu Desnoyers wrote: > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > > It's not clear to me why either of those things are necessary. An > > > example please? > > > > It's certainly possible that a global flag would need to be tested > > more than once. > > > > I guess it would work if a symbol is associated with a single > > definition. e.g. if there is a DEFINE_COND_CALL() somewhere > > and the individual cond calls reference it. > > Yes, but as you have probably understood, I want to have everything > embedded at the cond_call() site rather than polluting the rest of the > code with declarations.
And you do so at the expensive of the ability to have compile-time checks and the need to jump through a hash table at run-time. This doesn't seem like a good trade-off. Even if we -don't- do something like DEFINE_COND_CALL, it's still probably a good idea to not use raw strings inline and to instead use #defines. Raw strings are only slightly better than magic numbers. > Also, if we have the same cond_calls in different modules, in which > module shall it be defined ? This isn't a new problem. It exists for every other type of object in the kernel. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
