On Thu, May 31, 2007 at 06:45:17PM -0700, Mark Fasheh wrote: > On Fri, Jun 01, 2007 at 03:34:02AM +0200, Nick Piggin wrote: > > > Here's a nasty idea... Would it be valid for ->page_mkwrite to unlock the > > > page, so long as it's returned in a locked state? Though, do we even need > > > the page lock that early? It seemed to me that you were adding it for > > > consistency reasons (I could be wrong though). > > > > You could do that, but you'd have to probably check that it is > > within i_size after you relock it, I think... yeah, that might > > be the best thing for ocfs to do for now. > > Well, ocfs2 already does i_size checks in page_mkwrite, so we're covered > with respect to truncate races. > > I'm still not clear though - what was the reason for adding the page locking > there in the 1st place?
Yeah, its to cover page invalidation races. There is a description in an earlier patch's changelog. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
