>
>
> +static int try_get_ip_tcp_hdr(struct ehea_cqe *cqe, struct sk_buff *skb,
> + struct iphdr **iph, struct tcphdr **tcph)
> +{
> + int ip_len;
> +
> + /* non tcp/udp packets */
> + if (!cqe->header_length)
> + return -1;
> +
> + /* non tcp packet */
> + *iph = (struct iphdr *)(skb->data);
Why the indirection, copying of headers..
> + if ((*iph)->protocol != IPPROTO_TCP)
> + return -1;
> +
> + ip_len = (u8)((*iph)->ihl);
> + ip_len <<= 2;
> + *tcph = (struct tcphdr *)(((u64)*iph) + ip_len);
> +
> + return 0;
> +}
> +
>
This code seems to be duplicating a lot (but not all) of the TCP/IP
input path validation checks. This is a security problem if nothing else...
Also, how do you prevent DoS attacks from hostile TCP senders that send
huge number of back to back frames?
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
