* From: "Luck, Tony" * Date: Fri, 13 Apr 2007 09:45:49 -0700 >> So as ALIGN macro does the same work as ROUNDUP, > > Although it is mathematically the same operation, the > semantic associations of the name are important too. [] > Maybe this is because I started out in mathematics before > discovering that computers were so much fun, or maybe it > is a British-English bias ... I can't tell, but it makes > sense to me to use ROUNDUP in some places, and ALIGN in > others.
I agree. I came from neither one (still coming); first look and vague semantics of ALIGN macro, English confusion, a bit of laziness, led me to stupid messages about aligning, Linus being so kind to reply, a couple of months ago. Anyway i did that after some patching and re-patching that macro by gurus :). > If ROUNDUP isn't available everywhere, then it should be. To > avoid code duplication perhaps we should add: > > #define ROUNDUP(size, len) ALIGN((size), (len)) > > and delete the previous ROUNDUP definition? And i would vote for "align" via "round". ____ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
