On Thu, Mar 15, 2018 at 07:16:13PM +0100, Borislav Petkov wrote: > On Thu, Mar 15, 2018 at 01:10:54PM -0500, Josh Poimboeuf wrote: > > I liked OPCODE_BUFSIZE where it was before :-) Here it disrupts the > > readability of the function a bit IMO. > > My thinking is have it close by so that you don't have to go search for > its definition.
But knowing the value of OPCODE_BUFSIZE isn't needed for understanding the rest of the function, so it seems like clutter to me. Besides, that's what the vim cscope plugin is for :-) But I also don't have a strong opinion. -- Josh
