On Wed, May 30, 2007 at 07:14:49PM +0300, Meelis Roos wrote:
> The following patch makes mot_info __initdata since it is used only in
> __init functions. prep_pci.c change has been tested in real life on
> Motorola Powerstack II (compiles without modpost warnings and boots
> fine), pplus.c has not been tested but seems similar.
>
> Signed-off-by: Meelis Roos <[EMAIL PROTECTED]>
>
> diff --git a/arch/ppc/platforms/pplus.c b/arch/ppc/platforms/pplus.c
> index 8a1788c..9744108 100644
> --- a/arch/ppc/platforms/pplus.c
> +++ b/arch/ppc/platforms/pplus.c
> @@ -256,7 +256,7 @@ struct brd_info {
> const char *name;
> int (*map_irq) (struct pci_dev *, unsigned char, unsigned char);
> };
> -struct brd_info mot_info[] = {
> +__initdata struct brd_info mot_info[] = {
> {0x300, 0x00, 0x00, "MVME 2400", Genesis2_map_irq},
> {0x1E0, 0xE0, 0x00, "Mesquite cPCI (MCP750)", mesquite_map_irq},
> {0x1E0, 0xE1, 0x00, "Sitka cPCI (MCPN750)", sitka_map_irq},
> diff --git a/arch/ppc/platforms/prep_pci.c b/arch/ppc/platforms/prep_pci.c
> index 1df3150..bdec1f1 100644
> --- a/arch/ppc/platforms/prep_pci.c
> +++ b/arch/ppc/platforms/prep_pci.c
> @@ -792,7 +792,7 @@ raven_init(void)
> return 1;
> }
>
> -struct mot_info {
> +__initdata struct mot_info {
> int cpu_type; /* 0x100 mask assumes for Raven and
> Hawk boards that the level/edge are set */
> /* 0x200 if this board has a Hawk chip.
> */
> int base_type;
The way you place __initdata is bogus.
Please read following from init.h again:
* For initialized data:
* You should insert __initdata between the variable name and equal
* sign followed by value, e.g.:
*
* static int init_variable __initdata = 0;
* static char linux_logo[] __initdata = { 0x32, 0x36, ... };
If gcc happes to accept your placement does not make it correct.
It is still bogus and unreadable.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
