On Tue, 2007-05-29 at 14:38 -0700, David Brownell wrote: > On Tuesday 29 May 2007, Richard Purdie wrote: > > The LCD class device bits look fine to me. The only change I'd request > > is not to change the order of things in drivers/video/backlight/Kconfig. > > If you do want to reword one of those entries (which is what I think you > > wanted to do), send it as a separate patch please. > > One significant issue was screwed up sequencing causing > tools like 'xconfig' to display things wrong. Appended > is a patch fixing just that goof.
Put it like that, applied, thanks. :) (http://git.o-hand.com/?p=linux-rpurdie-backlight;a=shortlog;h=for-mm) > > David, any objections to the SPI bits? > > They seemed fine to me, other than the write_reg() macro > having an embedded 'goto' ... explicitly against the > Documentation/CodingStyle guidelines. ("Chapter 12", > point 1 = "macros that affect code flow".) Yes, even if it will make the code more ugly in a way, I think it needs to be changed... > I like seeing more of the SPI drivers go upstream. ;) ;) Cheers, Richard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
