On Mon, May 28, 2007 at 02:56:32PM -0700, Andrew Morton wrote: > On Mon, 28 May 2007 20:36:58 +0100 Russell King <[EMAIL PROTECTED]> wrote: > > > On Wed, May 23, 2007 at 05:27:39PM +0100, Alan Cox wrote: > > > Add the ioctls and values needed for this to the ARM26/ARM32 ports. The > > > actual code has been in the base kernel for a while and automatically > > > turns on when a port sets the required defines. > > > > Did you forget to provide a termios2 structure for ARM? Hope you > > remembered for the other arches: > > > > drivers/char/tty_ioctl.c: In function `set_termios': > > drivers/char/tty_ioctl.c:429: error: invalid application of `sizeof' to > > incomplete type `termios2' > > drivers/char/tty_ioctl.c: In function `n_tty_ioctl': > > drivers/char/tty_ioctl.c:732: error: invalid application of `sizeof' to > > incomplete type `termios2' > > > > Will copy the i386 version into ARM's termbits.h > > > > I think Alan's per-arch patch was dependent upon an earlier patch. He > fooled everyone by sending them out in random order, without sequence > nnumbers and without telling anyone the dependencies. And the add-termios2 > patch was a single megapatch whereas the enablement patches were a per-arch > sprinkle. > > > Here's tha arm bit of > lots-of-architectures-enable-arbitary-speed-tty-support.patch:
I hope that isn't because it's wrong. It's "termios2" not "termios_2". > Or you can just drop this patch and I'll resend it once > lots-of-architectures-enable-arbitary-speed-tty-support.patch is merged up. I think I'd prefer to commit my own version copied from x86, which at least passes a build test. Doing that now. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
