On Sat, 26 May 2007, Jan Engelhardt wrote: > +Testing for a flag, as done in the following example, is redundant and > +can be shortened. > + > + if ((v & GFP_KERNEL) == GFP_KERNEL) > + return; > + > +should become > + > + if (v & GFP_KERNEL) > + return;
This looks wrong to me. These two are only equivalent if the "flag" only has 1 bit. And already here you fall into this trap: #define GFP_KERNEL (__GFP_WAIT | __GFP_IO | __GFP_FS) Thanks Guennadi --- Guennadi Liakhovetski - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
