Hi.
Arnd Bergmann wrote:
>> + switch (dev_type) {
>> + case PS3_DEV_TYPE_STOR_DISK:
>> + match_id = PS3_MATCH_ID_STOR_DISK;
>> + break;
>> +
>> + case PS3_DEV_TYPE_STOR_ROM:
>> + match_id = PS3_MATCH_ID_STOR_ROM;
>> + break;
>> +
>> + case PS3_DEV_TYPE_STOR_FLASH:
>> + match_id = PS3_MATCH_ID_STOR_FLASH;
>> + break;
>> +
>> + default:
>> + return 0;
>> + }
>
> Why do you have separate constants for PS3_DEV_TYPE_* and
> PS3_MATCH_ID_*? If you don't do any conversion, this driver
> will immediately work for additional types as well, if more
> get added later.
I noticed we have some redundancy in the constants and such
now that we have unified the device support. I planned to go
through and try to clean up what I can.
-Geoff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
