> > Also who cares? The commit message is perfectly clear. > > I do care about newcomers really learning on how to write a proper > commit message. > > The commit messsage should really say why the patch is needed, no what the > patch does. >
It fixes a checkpatch warning. The warning was right there in the patch description! > After several trivial patches newcomers will get into more serious stuff and > I wouldn't > want to see a patch with commit message like this: > > iio: Change bit 1 of status register > You seem to be complaining about about an imaginary patch from the future??? If you've really built a time machine then focus on killing Hitler instead of complaining about trivial bullshit. regards, dan carpenter
