Re: [PATCH 02/20] lightnvm: add controller capabilities to 2.0

[Matias Bjørling]

On 02/21/2018 10:26 AM, Javier González wrote:
Assign missing mccap value on 2.0 path
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
  drivers/nvme/host/lightnvm.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index c81e64cc20d7..969bb874850c 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -392,6 +392,8 @@ static int nvme_nvm_setup_20(struct nvme_nvm_id20 *id,
        dev_geo->c.ws_opt = le32_to_cpu(id->ws_opt);
        dev_geo->c.mw_cunits = le32_to_cpu(id->mw_cunits);
  
+	dev_geo->c.mccap = le32_to_cpu(id->mccap);
+
        dev_geo->c.trdt = le32_to_cpu(id->trdt);
        dev_geo->c.trdm = le32_to_cpu(id->trdm);
        dev_geo->c.tprt = le32_to_cpu(id->twrt);


The mccap field between 1.2 and 2.0 is orthogonal. They represent two 
different capabilities fields. The mccap has to be interpreted if used.