On Thu, Feb 15, 2018 at 9:06 AM, Christopher Lameter <c...@linux.com> wrote: > On Thu, 15 Feb 2018, Matthew Wilcox wrote: > >> I dunno. Yes, there's macro trickery going on here, but it certainly >> resembles a function. It doesn't fail any of the rules laid out in that >> chapter of coding-style about unacceptable uses of macros. > > It sure looks like a function but does magic things with the struct > parameter. So its not working like a function and the capitalization makes > one aware of that.
I think readability trumps that -- nearly everything else in the kernel that hides these kinds of details is lower case. -Kees -- Kees Cook Pixel Security
