Hi Philippe,
On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne
<pombreda...@nexb.com> wrote:
> On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
> <miguel.ojeda.sando...@gmail.com> wrote:
>> Cc: Willy Tarreau <w...@1wt.eu>
>> Cc: Geert Uytterhoeven <ge...@linux-m68k.org>
>> Cc: Linus Walleij <tr...@df.lth.se>
>> Cc: Robin van der Gracht <ro...@protonic.nl>
>> Cc: Paul Burton <paul.bur...@mips.com>
>> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com>
>> ---
>
> <snip>
>
>> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
>> index b454dfce60d9..aa960efc32f6 100644
>> --- a/include/linux/cfag12864b.h
>> +++ b/include/linux/cfag12864b.h
>> @@ -1,25 +1,11 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> Per the doc [1] you should be using instead this in a .h:
> /* SPDX-License-Identifier: GPL-2.0 */
>
> I know this can be surprising. This has been discussed on list quite
> lot and the doc has some rationale.
>
> <snip>
>
>> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
>> index cb311798e0bc..2a1c985fedea 100644
>> --- a/include/linux/ks0108.h
>> +++ b/include/linux/ks0108.h
>> @@ -1,25 +1,11 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> Same comment as above.
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>
Obviously we need a check in scripts/checkpatch.pl, to catch this
before submission...
Care to send a patch?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
