Commit-ID: a73e24d240bc136619d382b1268f34d75c9d25ce Gitweb: https://git.kernel.org/tip/a73e24d240bc136619d382b1268f34d75c9d25ce Author: Jiri Olsa <jo...@kernel.org> AuthorDate: Thu, 15 Feb 2018 13:26:34 +0100 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitDate: Fri, 16 Feb 2018 14:25:59 -0300
perf tools: Do not create kernel maps in sample__resolve() There's no need for kernel maps to be allocated at this point - sample processing. We search for kernel maps using the kernel map_groups in machine::kmaps which is static. If vmlinux maps for any reason still don't exist, the search correctly fails because they are not in the map group. Signed-off-by: Jiri Olsa <jo...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <pet...@infradead.org> Link: http://lkml.kernel.org/r/20180215122635.24029-9-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com> --- tools/perf/util/event.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index 4644e75..f0a6cbd 100644 --- a/tools/perf/util/event.c +++ b/tools/perf/util/event.c @@ -1588,17 +1588,6 @@ int machine__resolve(struct machine *machine, struct addr_location *al, return -1; dump_printf(" ... thread: %s:%d\n", thread__comm_str(thread), thread->tid); - /* - * Have we already created the kernel maps for this machine? - * - * This should have happened earlier, when we processed the kernel MMAP - * events, but for older perf.data files there was no such thing, so do - * it now. - */ - if (sample->cpumode == PERF_RECORD_MISC_KERNEL && - machine__kernel_map(machine) == NULL) - machine__create_kernel_maps(machine); - thread__find_addr_map(thread, sample->cpumode, MAP__FUNCTION, sample->ip, al); dump_printf(" ...... dso: %s\n", al->map ? al->map->dso->long_name :
