Hi,
> -----Original Message-----
> From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi-
> ow...@vger.kernel.org] On Behalf Of Andy Shevchenko
> Sent: Tuesday, January 30, 2018 10:18 AM
> To: Kai-Heng Feng <kai.heng.f...@canonical.com>
> Cc: Rafael J. Wysocki <r...@rjwysocki.net>; Len Brown <l...@kernel.org>; ACPI
> Devel Maling List <linux-a...@vger.kernel.org>; Linux Kernel Mailing List
> <linux-
> ker...@vger.kernel.org>; Mario Limonciello <mario.limoncie...@dell.com>
> Subject: Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS
> 9570 and
> Precision M5530
>
> On Tue, Jan 30, 2018 at 8:07 AM, Kai-Heng Feng
> <kai.heng.f...@canonical.com> wrote:
> > The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out
> > of box.
> >
> > The touchpad relies on its _INI method to update its _HID value from
> > XXXX0000 to SYNA2393.
> > Also, the _STA relies on value of I2CN to report correct status.
> >
> > Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be
> > correctly set up, and _INI can get run. The ACPI table in this machine
> > is designed to get parsed this way.
I thought I would give everyone an update: we are getting close to finishing
patches to enable this term list parsing by default as well as a few other
fixes with forward referencing of package elements. Once we have established
that these patches are stable, we will get rid of
acpi_gbl_parse_table_as_term_list. So this quirk may not be needed in the near
future...
Erik
> >
> > Also, change the quirk table to a more generic name.
>
> > +static int set_gbl_term_list(const struct dmi_system_id *id) {
> > + pr_notice("%s detected - parse the entire table as a term_list\n",
> > + id->ident);
> > + acpi_gbl_parse_table_as_term_list = 1;
> > + return 0;
> > +}
> > #endif
>
> The above should be outside of another #ifdef. Basically after the above
> #endif.
>
> > #else
>
> > #endif
>
> > @@ -1005,7 +1034,7 @@ void __init acpi_early_init(void)
>
> > * If the machine falls into the DMI check table,
> > * DSDT will be copied to memory
> > */
>
> It might make sense to adjust comment above that it's about quirks in general.
> And, if needed, move current content to actual DMI group of records.
>
> > - dmi_check_system(dsdt_dmi_table);
> > + dmi_check_system(acpi_quirks_dmi_table);
>
> --
> With Best Regards,
> Andy Shevchenko
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the
> body of
> a message to majord...@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
