On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote:
> On Sun, 2018-01-28 at 15:11 +0000, Corentin Labbe wrote:
> > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups")
> > 10 years after, we could remove it.
>
> OK, now you could remove the prototypes and probably
> CONFIG_INFINIBAND_CXGB3_DEBUG too.
>
> There is a DEBUG test and many uses of pr_debug
> that would have modified behavior.
>
> The pr_debug uses would only be emitted via a
> dynamic_debug enable and the #ifdef DEBUG is
> probably not necessary or useful as it guards
> a BUG_ON.
>
> drivers/infiniband/hw/cxgb3/Kconfig | 9 ---------
> drivers/infiniband/hw/cxgb3/Makefile | 2 --
> drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 ---------
> drivers/infiniband/hw/cxgb3/iwch_cq.c | 7 -------
> 4 files changed, 27 deletions(-)
Yes, can you resend the patch with Joe's hunks as well?
Thanks,
Jason
