On Sat, 19 May 2007 12:33:04 +0200 (MEST) Andrea Righi <[EMAIL PROTECTED]>
wrote:
> Bernd Eckenfels wrote:
> > In article <[EMAIL PROTECTED]> you wrote:
> >> printk("%s/%d: potentially unexpected fatal signal %d.\n",
> >> current->comm, current->pid, signr);
> >
> > can we have both KERN_WARNING please?
> >
> > Gruss
> > Bernd
>
> Depends on print_fatal_signals patch.
>
> ---
>
> Limit the rate of print_fatal_signal() to avoid potential denial-of-service
> attacks.
>
> Signed-off-by: Andrea Righi <[EMAIL PROTECTED]>
>
> diff -urpN linux-2.6.22-rc1-mm1/kernel/signal.c
> linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c
> --- linux-2.6.22-rc1-mm1/kernel/signal.c 2007-05-19 11:25:24.000000000
> +0200
> +++ linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c 2007-05-19
> 11:30:00.000000000 +0200
> @@ -790,7 +790,10 @@ static void print_vmas(void)
>
> static void print_fatal_signal(struct pt_regs *regs, int signr)
> {
> - printk("%s/%d: potentially unexpected fatal signal %d.\n",
> + if (unlikely(!printk_ratelimit()))
> + return;
> +
> + printk(KERN_WARNING "%s/%d: potentially unexpected fatal signal %d.\n",
> current->comm, current->pid, signr);
>
> #ifdef __i386__
Well OK. But vdso-print-fatal-signals.patch is designated not-for-mainline
anyway.
I think the DoS which you identify has been available for a very long time
on ia64, x86_64 and perhaps others.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
