We copy in null terminated strings "on" and "off", no
need to zero out devkmsg_log_str in control_devkmsg().

Signed-off-by: Sergey Senozhatsky <sergey.senozhat...@gmail.com>
---
 kernel/printk/printk.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index d70927c384f3..9faddcfd3994 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -136,13 +136,10 @@ static int __init control_devkmsg(char *str)
        /*
         * Set sysctl string accordingly:
         */
-       if (devkmsg_log == DEVKMSG_LOG_MASK_ON) {
-               memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE);
-               strncpy(devkmsg_log_str, "on", 2);
-       } else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF) {
-               memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE);
-               strncpy(devkmsg_log_str, "off", 3);
-       }
+       if (devkmsg_log == DEVKMSG_LOG_MASK_ON)
+               strcpy(devkmsg_log_str, "on");
+       else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF)
+               strcpy(devkmsg_log_str, "off");
        /* else "ratelimit" which is set by default. */
 
        /*
-- 
2.16.0

Reply via email to