From: "Antonino A. Daplas" <[EMAIL PROTECTED]> Date: Thu, 17 May 2007 18:51:22 +0800
> On Thu, 2007-05-17 at 10:49 +0100, Christoph Hellwig wrote: > > On Thu, May 17, 2007 at 05:33:48AM +0800, Antonino A. Daplas wrote: > > > -#if defined(__sparc__) && !defined(__sparc_v9__) > > > - /* Should never get here, all fb drivers should have their own > > > - mmap routines */ > > > - return -EINVAL; > > > -#else > > > - /* !sparc32... */ > > > + if (fb_mmap_required()) > > > + return -EINVAL; > > > + > > > > I don't like this bit. > > Me too, actually. I did it this way because I don't want to deviate from > the old code too much. Since all sparc32 drivers are either linked to > sbuslib.c or has their own fb_mmap method, the above test is redundant. > I'll leave the decision to remove the above test to David Miller. Feel free to remove it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
