On Wed, 2007-05-16 at 14:53 -0700, David Miller wrote: > From: "Antonino A. Daplas" <[EMAIL PROTECTED]> > Date: Thu, 17 May 2007 05:33:48 +0800 > > > Move arch-specific bits of fb_mmap() to their respective subdirectories > > > > Signed-off-by: Antonino Daplas <[EMAIL PROTECTED]> > > --- > > Hi all, > > > > Please let me know if there are mistakes with this patch. > > Thank you for doing this work. > > __sparc_v9__ means CONFIG_SPARC64, if that is not defined it's > CONFIG_SPARC32, so you could simplify this patch a lot. > > 1) Remove __sparc_v9__ ifdefs from asm-sparc64/fb.h > 2) Define fb_mmap_required() to return 0 in asm-sparc64/fb.h > 3) Define fb_mmap_required() to return 1 in asm-sparc/fb.h > 4) Remove all the sparc ifdef stuff you added to linux/fb.h > 5) There won't be a default fb_mmap_required() provided by > linux/fb.h on platforms other than sparc ones, you'll need > to provide one in order for the build to work non-sparc since > this call is unconditional in fbmem.c: > > + if (fb_mmap_required()) > + return -EINVAL; > > With those fixes: >
Okay, I see what you mean. I will concoct another patch later. Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
