From: Markus Elfring <[email protected]> Date: Sun, 7 Jan 2018 21:42:07 +0100
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- drivers/misc/apds9802als.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/misc/apds9802als.c b/drivers/misc/apds9802als.c index d8ac036f01ab..fa548796c92e 100644 --- a/drivers/misc/apds9802als.c +++ b/drivers/misc/apds9802als.c @@ -231,10 +231,9 @@ static int apds9802als_probe(struct i2c_client *client, struct als_data *data; data = kzalloc(sizeof(struct als_data), GFP_KERNEL); - if (data == NULL) { - dev_err(&client->dev, "Memory allocation failed\n"); + if (!data) return -ENOMEM; - } + i2c_set_clientdata(client, data); res = sysfs_create_group(&client->dev.kobj, &m_als_gr); if (res) { -- 2.15.1
