On 01/03/18 01:49, Vincent Legoll wrote: > No need to get into the submenu to disable all VIRTIO-related > config entries. > > This makes it easier to disable all VIRTIO config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the outside menu. > > This is only intended to change menuconfig UI, not change > the config dependencies. > > v2: add "default y" to avoid breaking existing configs > > Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com>
For a single patch (not 2 or more in a series), please just use one email with the patch description etc. in it. No need for a cover letter. > --- > drivers/virtio/Kconfig | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index cff773f15b7e..290a1875e1d3 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -5,7 +5,11 @@ config VIRTIO > bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG > or CONFIG_S390_GUEST. > > -menu "Virtio drivers" > +menuconfig VIRTIO_MENU > + bool "Virtio drivers" > + default y The 2 lines above should be indented only with 1 tab. They should not line up with the help text above (help text is indented more than other Kconfig lines). After that little style thing is fixed, you can add: Reviewed-by: Randy Dunlap <rdun...@infradead.org> Tested-by: Randy Dunlap <rdun...@infradead.org> # works for me and even though this will disable the drivers that are listed immediately inside this if/endif block, there are several other drivers that select VIRTIO, so it can be slightly tricky to figure out what is causing CONFIG_VIRTIO to be enabled after having disabled CONFIG_VIRTIO_MENU. Thanks. > + > +if VIRTIO_MENU > > config VIRTIO_PCI > tristate "PCI driver for virtio devices" > @@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES > > If unsure, say 'N'. > > -endmenu > +endif # VIRTIO_MENU > -- ~Randy
