Hi Oza,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.15-rc5]
[cannot apply to pci/next pm/linux-next next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20171228-222058
config: i386-randconfig-i0-201752 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/pci/pcie/pcie-err.o: In function `pci_reset_link':
>> drivers/pci/pcie/pcie-err.c:194: undefined reference to 
>> `pci_find_aer_service'

vim +194 drivers/pci/pcie/pcie-err.c

   178  
   179  pci_ers_result_t pci_reset_link(struct pci_dev *dev)
   180  {
   181          struct pci_dev *udev;
   182          pci_ers_result_t status;
   183          struct pcie_port_service_driver *driver;
   184  
   185          if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
   186                  /* Reset this port for all subordinates */
   187                  udev = dev;
   188          } else {
   189                  /* Reset the upstream component (likely downstream 
port) */
   190                  udev = dev->bus->self;
   191          }
   192  
   193          /* Use the aer driver of the component firstly */
 > 194          driver = pci_find_aer_service(udev);
   195  
   196          if (driver && driver->reset_link) {
   197                  status = driver->reset_link(udev);
   198          } else if (udev->has_secondary_link) {
   199                  status = pci_default_reset_link(udev);
   200          } else {
   201                  dev_printk(KERN_DEBUG, &dev->dev,
   202                          "no link-reset support at upstream device %s\n",
   203                          pci_name(udev));
   204                  return PCI_ERS_RESULT_DISCONNECT;
   205          }
   206  
   207          if (status != PCI_ERS_RESULT_RECOVERED) {
   208                  dev_printk(KERN_DEBUG, &dev->dev,
   209                          "link reset at upstream device %s failed\n",
   210                          pci_name(udev));
   211                  return PCI_ERS_RESULT_DISCONNECT;
   212          }
   213  
   214          return status;
   215  }
   216  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to