On Mon, Dec 25, 2017 at 10:31:00PM +0800, Jia Zhang wrote:
> I used the interface /sys/devices/system/cpu/microcode/reload, not
> /dev/cpu/microcode.
>
> Sound like using c->microcode is already enough.
> So I'm not sure why calling collect_cpu_info() is necessary for the
> old method. c->microcode can reflect the correct version as long as it
> always syncs up with the recent loaded microcode update.
Yes, it probably will work in most cases because we do
collect_cpu_info() on init and we do refresh the microcode revision
after application but there might be some obscure case and configuration
[ and the microcode loader has a gazillion possible use cases :-\ ]
where it might not work. That's why I mentioned doing it in
microcode_open() as a precation.
But we can leave that for later, if at all. This old method is deprecated
anyway.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
