On Tue, 5 Dec 2017 17:49:56 +0900 Masahiro Yamada <yamada.masah...@socionext.com> wrote:
> Use macros from <linux/kernel.h> to make the code readable. > The compiler warning will be kept suppressed. Applied. Thanks, Boris > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > --- > > drivers/mtd/nand/cafe_nand.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/cafe_nand.c b/drivers/mtd/nand/cafe_nand.c > index add4613..2af5e35 100644 > --- a/drivers/mtd/nand/cafe_nand.c > +++ b/drivers/mtd/nand/cafe_nand.c > @@ -737,12 +737,8 @@ static int cafe_nand_probe(struct pci_dev *pdev, > } > > /* Set up DMA address */ > - cafe_writel(cafe, cafe->dmaaddr & 0xffffffff, NAND_DMA_ADDR0); > - if (sizeof(cafe->dmaaddr) > 4) > - /* Shift in two parts to shut the compiler up */ > - cafe_writel(cafe, (cafe->dmaaddr >> 16) >> 16, NAND_DMA_ADDR1); > - else > - cafe_writel(cafe, 0, NAND_DMA_ADDR1); > + cafe_writel(cafe, lower_32_bits(cafe->dmaaddr), NAND_DMA_ADDR0); > + cafe_writel(cafe, upper_32_bits(cafe->dmaaddr), NAND_DMA_ADDR1); > > cafe_dev_dbg(&cafe->pdev->dev, "Set DMA address to %x (virt %p)\n", > cafe_readl(cafe, NAND_DMA_ADDR0), cafe->dmabuf);
