* Jens Axboe <ax...@kernel.dk> wrote:
> On 12/06/2017 12:15 AM, Omar Sandoval wrote:
> > From: Omar Sandoval <osan...@fb.com>
> >
> > Commit 50816c48997a ("sched/wait: Standardize internal naming of
> > wait-queue entries") changed the behavior of add_wait_queue() from
> > inserting the wait entry at the head of the wait queue to the tail of
> > the wait queue. That commit was a cleanup and didn't mention any
> > functional changes so it was likely unintentional. This change in
> > behavior theoretically breaks wait queues which mix exclusive and
> > non-exclusive waiters, as non-exclusive waiters will not be woken up if
> > they are queued behind enough exclusive waiters.
>
> Ingo? You've been silent on this issue, which is somewhat odd since
> your cosmetic renaming patch introduced this behavioral change.
>
> Omar, should probably turn that into a proper Fixes: line as
> well.
>
> > Signed-off-by: Omar Sandoval <osan...@fb.com>
>
> Reviewed-by: Jens Axboe <ax...@kernel.dk>
Thanks!
I've applied the fix and will send it to Linus later today.
Thanks,
Ingo
